Workspace directory structure#305
Conversation
This is a common convention for workspace layout. Maybe not quite so prevalent to be considered *the* way it is done, but almost. For example, both `wasm-bindgen`'s and `cargo`'s workspace and directory layout follow this convention.
The "wasmtime" part is already implied ;) Note that this doesn't change crate names at all, just the directories in the repository. So the `wasmtime-jit` crate is still named `wasmtime-jit`, but it lives at `crates/jit` instead of `crates/wasmtime-jit` in the repo now. See `wasm-bindgen`'s workspace directory structure for conventions and prior art.
|
I really like following community conventions, and the structure proposed here works for me. It would be nice to keep this repo and Cranelift consistent, so we should consider making a similar change in Cranelift. Would you mind opening an issue to ask if folks on the Cranelift side have opinions? We do have a lot of PRs open right now. Would this change cause conflicts outside of the Cargo.toml etc. changes? I believe I've seen git be somewhat intelligent about merging through renames. As a historical note, we switched away from |
I would hope so, but I'm not 100% sure!
Sure thing, opened https://github.com/CraneStation/cranelift/issues/956 |
This is largely the same as bytecodealliance#305, but updated for the current tree.
|
I think this was covered in #512, so gonna close this |
Line counting for ISLE code. Based on bytecodealliance#305. Co-authored-by: Chris Fallin <chris@cfallin.org>
3 participants
Two little tidy changes to workspace directory structure. See commit messages for details.
These conventions are used elsewhere in the Rust world, but not so prevalent that not doing this is clearly going against community norms, so def feel free to reject this PR if you don't like it or its too much of a hassle for rebasing open PRs.
r? @sunfishcode