Reorganize the codebase#512
Merged
sunfishcode merged 17 commits intobytecodealliance:masterfrom Nov 8, 2019
Merged
Conversation
This is largely the same as bytecodealliance#305, but updated for the current tree.
fitzgen
approved these changes
Nov 8, 2019
Member
fitzgen
left a comment
fitzgen
left a comment
There was a problem hiding this comment.
Looks good 👍
I bet we have to also update the wasmtime CLI dist build script for CI as well, since I don't see that here, but I do see CI failing.
kubkon
approved these changes
Nov 8, 2019
Member
kubkon
left a comment
kubkon
left a comment
There was a problem hiding this comment.
This looks really good! I'm glad we're finally making this reorg :-)
- Move spec_testsuite and misc_testsuite under the tests directory. - Remove some redundant tests from filetests. - Move wat tests to wat/tests.
Member
Author
|
Ok, landing, so we can iterate from here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reorganizes the codebase along the lines of #305, updated for the current tree. Subcrates are moved to
crates/, with thewasmtime-prefix removed from the directory name (crate names are unchanged).Also, this renames the
wasmtime-apicrate towasmtime, as it's aiming to be the primary library interface to Wasmtime. And it renames the top-level crate towasmtime-cli.