[wasmtime-py] Build wheels for python37 on linux#310
Merged
tschneidereit merged 2 commits intobytecodealliance:masterfrom Aug 30, 2019
Merged
[wasmtime-py] Build wheels for python37 on linux#310tschneidereit merged 2 commits intobytecodealliance:masterfrom
tschneidereit merged 2 commits intobytecodealliance:masterfrom
Conversation
tschneidereit
approved these changes
Aug 30, 2019
Member
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
I'm really surprised by how little time compiling Python takes! Seems acceptable for the time being, at least.
r=me with the two small nits addressed.
ci/setup_centos6_python37.sh
Outdated
| tar -zxvf OpenSSL_1_1_1c.tar.gz | ||
| cd openssl-OpenSSL_1_1_1c | ||
| ./Configure shared zlib linux-x86_64 | ||
| make |
Member
There was a problem hiding this comment.
Can you change this to make -sj4 to speed it up? Using more cores obviously helps, but all the output turns out to slow things down, so -s also helps.
ci/setup_centos6_python37.sh
Outdated
| tar xzf Python-3.7.3.tgz | ||
| cd Python-3.7.3 | ||
| ./configure | ||
| make |
Member
|
I pushed a commit with the changes I asked for above, which shaved off another ~3 minutes from the duration of this job. |
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
Fix the `cond_holds` macro in the `LE` case. The original was transcribed from the documentation: https://developer.arm.com/documentation/dui0801/l/Condition-Codes/Condition-code-suffixes-and-related-flags The description of `GT` and `LE` is: ``` GT Z clear, N and V the same Signed > LE Z set, N and V differ Signed <= ``` Unfortunately the meaning of comma changes here: AND in the first case, OR in the second. See: https://community.arm.com/arm-community-blogs/b/architectures-and-processors-blog/posts/condition-codes-1-condition-flags-and-codes The description here removes the ambiguity: ``` gt Signed greater than. (Z==0) && (N==V) le Signed less than or equal. (Z==1) || (N!=V) ``` This bug was likely the cause of the problems in bytecodealliance#310.
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
Code generator for float constant macros. We only have a couple at the moment, but the fix for bytecodealliance#310 motivates adding more cases that are delicate to get right.
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
Fix the failing float to integer conversion test cases, and correct specs that caused the prior version to verify: * `cond_holds` macro was broken (fixed in bytecodealliance#314) * The `min_int_as_fp` macros were incorrect for `i32::MIN` as `f64` * The special-case for `f64` to `i32` was not specified in `fcvt_to_sint` Fixes bytecodealliance#310
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
Generator for the `{min,max}_fp_value` specs.
The spec is uglier, but it's easier to make sure the floating point bit
patterns match up with the corresponding Rust.
Updates bytecodealliance#310
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
Run a subset of Cranelift and Wasmtime tests in CI to mitigate problems such as bytecodealliance#310. Fixes bytecodealliance#311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.