Provide pre-compiled shared libraries for C-API#311
Merged
tschneidereit merged 2 commits intobytecodealliance:masterfrom Aug 30, 2019
Merged
Provide pre-compiled shared libraries for C-API#311tschneidereit merged 2 commits intobytecodealliance:masterfrom
tschneidereit merged 2 commits intobytecodealliance:masterfrom
Conversation
yurydelendik
force-pushed
the
wasmtime-api-build
branch
from
ecc6087 to
2f76800
Compare
yurydelendik
force-pushed
the
wasmtime-api-build
branch
from
2f76800 to
d933d58
Compare
tschneidereit
requested changes
Aug 30, 2019
Member
tschneidereit
left a comment
tschneidereit
left a comment
There was a problem hiding this comment.
@yurydelendik thank you for doing this! \o/
It all looks great, except for two things:
- can you split these out into their own archives per platform? Containing the license, README, header file, and shared libraries.
- Please call the archives, binaries, and headers something like
libwasmtime-c-api.
yurydelendik
force-pushed
the
wasmtime-api-build
branch
3 times, most recently
from
cca1bd7 to
4626282
Compare
yurydelendik
force-pushed
the
wasmtime-api-build
branch
from
4626282 to
e618c14
Compare
avanhatt
pushed a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
Run a subset of Cranelift and Wasmtime tests in CI to mitigate problems such as bytecodealliance#310. Fixes bytecodealliance#311
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #309