Merged
Conversation
Contributor
Author
|
Rendered on my branch. I'm going to delete the branch once PR is merged. Please note the are more changes than only this markdown file. |
f15fa1b to
31e0773
Compare
Contributor
Author
|
Note to myself (TODO):
|
Merged
a8ed12d to
1cb7ed6
Compare
sunfishcode
reviewed
Sep 23, 2019
1cb7ed6 to
2a8e226
Compare
avanhatt
added a commit
to wellesley-prog-sys/wasmtime
that referenced
this pull request
Apr 9, 2025
Verify most lowerings of `f{32,64}const`.
* Restructured to avoid recursion and allow chaining
* `AMode.Const` is not handled, preventing one `f64const` expansion from
verifying
* Model of `ASIMDMovModImm` and `VecDupImm` spec are incomplete, but
enough to verify the zero case.
Mostly borrowed from bytecodealliance#285, with a critical fix for the `value32` macro
in the `asimd_fp_mod_imm_from_u64` spec.
Co-authored-by: Alexa VanHattum <av111@wellesley.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #334.