Skip to content

Cache config docs#337

Merged
sunfishcode merged 1 commit intobytecodealliance:masterfrom
mrowqa:cache-config-docs
Sep 23, 2019
Merged

Cache config docs#337
sunfishcode merged 1 commit intobytecodealliance:masterfrom
mrowqa:cache-config-docs

Conversation

@mrowqa
Copy link
Contributor

@mrowqa mrowqa commented Sep 12, 2019

Depends on #334.

@mrowqa
Copy link
Contributor Author

mrowqa commented Sep 12, 2019

Rendered on my branch. I'm going to delete the branch once PR is merged. Please note the are more changes than only this markdown file.

@mrowqa mrowqa force-pushed the cache-config-docs branch 3 times, most recently from f15fa1b to 31e0773 Compare September 16, 2019 22:48
@mrowqa
Copy link
Contributor Author

mrowqa commented Sep 17, 2019

Note to myself (TODO):

  • update installer, CI & other places that should know about CACHE_CONFIGURATION.md
  • add call-to-contribution to the docs if someone wants to alter some default value

@mrowqa mrowqa mentioned this pull request Sep 17, 2019
@mrowqa mrowqa force-pushed the cache-config-docs branch 2 times, most recently from a8ed12d to 1cb7ed6 Compare September 19, 2019 17:11
@mrowqa mrowqa marked this pull request as ready for review September 23, 2019 22:24
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@sunfishcode sunfishcode merged commit dde1c6b into bytecodealliance:master Sep 23, 2019
@mrowqa mrowqa deleted the cache-config-docs branch September 23, 2019 23:07
avanhatt added a commit to wellesley-prog-sys/wasmtime that referenced this pull request Apr 9, 2025
Verify most lowerings of `f{32,64}const`.

* Restructured to avoid recursion and allow chaining
* `AMode.Const` is not handled, preventing one `f64const` expansion from
verifying
* Model of `ASIMDMovModImm` and `VecDupImm` spec are incomplete, but
enough to verify the zero case.

Mostly borrowed from bytecodealliance#285, with a critical fix for the `value32` macro
in the `asimd_fp_mod_imm_from_u64` spec.

Co-authored-by: Alexa VanHattum <av111@wellesley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants