Skip to content

Cache worker tests#342

Merged
sunfishcode merged 1 commit intobytecodealliance:masterfrom
mrowqa:cache-tests
Sep 25, 2019
Merged

Cache worker tests#342
sunfishcode merged 1 commit intobytecodealliance:masterfrom
mrowqa:cache-tests

Conversation

@mrowqa
Copy link
Contributor

@mrowqa mrowqa commented Sep 17, 2019

Depends on #337.

@mrowqa mrowqa force-pushed the cache-tests branch 2 times, most recently from 4bb69af to 9f16f0b Compare September 18, 2019 23:09
@mrowqa
Copy link
Contributor Author

mrowqa commented Sep 20, 2019

TODO:

  • the tests sometimes fail - fix it

One thing is they are not deterministic and depend on system clock (mtime when writing to the disk), so that's one possible reason - it could be the reason if setting mtime by the system is nondeterministic because of some optimizations.

@mrowqa mrowqa force-pushed the cache-tests branch 2 times, most recently from 7cc255d to 32f08d4 Compare September 23, 2019 23:10
@mrowqa mrowqa marked this pull request as ready for review September 23, 2019 23:10
self.cache_config
.allowed_clock_drift_for_files_from_future(),
)
.expect("Brace your cache, the end of the world is coming (time overflow)");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could actually call it "the next Big Bang" 😆

@sunfishcode sunfishcode merged commit 512b119 into bytecodealliance:master Sep 25, 2019
@mrowqa mrowqa deleted the cache-tests branch September 25, 2019 21:41
avanhatt pushed a commit to wellesley-prog-sys/wasmtime that referenced this pull request Sep 10, 2025
Set the solver strategy when using `z3`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants