x64: Add native lowering for scalar fma#4539
Merged
jameysharp merged 1 commit intobytecodealliance:mainfrom Aug 11, 2022
Merged
x64: Add native lowering for scalar fma#4539jameysharp merged 1 commit intobytecodealliance:mainfrom
fma#4539jameysharp merged 1 commit intobytecodealliance:mainfrom
Conversation
afonso360
changed the title
fmafma
github-actions
bot
added
cranelift
Contributor
|
This PR has unfortunately gone stale, but I'd like to not lose track of it. @afonso360, could you give it a rebase? |
afonso360
force-pushed
the
x86-vfmadd213s
branch
from
26d5b00 to
d3cfdf0
Compare
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Contributor
Author
|
Changes with the last rebase:
|
Contributor
Author
|
CI failures seem spurious |
elliottt
approved these changes
Aug 11, 2022
Member
elliottt
left a comment
elliottt
left a comment
There was a problem hiding this comment.
This looks great to me! Thanks for adding all the filetest cases!
Contributor
|
CI failures are because today's release of Rust 1.63 reports a new warning. #4691 is merged fixing that, so please rebase and then hopefully CI will pass. |
Use `vfmadd213{ss,sd}` for these lowerings.
afonso360
force-pushed
the
x86-vfmadd213s
branch
from
d3cfdf0 to
522bb54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey
This PR adds a lowering for scalar
fmafor x64. Additionally we enable this operation in the CLIF Fuzzer.cc: @abrown