Update wasm-tools crates to latest versions.#6394
Conversation
This included stubbing out unimplemented GC-related things and updating coredump generation to include the coredump spec changes.
| saturating_float_to_int: _, | ||
| sign_extension: _, | ||
| floats: _, | ||
| gc: _, |
There was a problem hiding this comment.
Mind binding this as gc and asserting it's false down below (like memory_control)? We'll want to turn this on eventually and we won't want to forget to add handling here.
src/commands/run.rs
Outdated
| let mut stacksection = wasm_encoder::CoreDumpStackSection::new("main"); | ||
| let mut modulenames = std::collections::HashSet::new(); | ||
| for f in bt.frames() { | ||
| modulenames.insert(f.module_name().unwrap_or("<unknown>")); |
There was a problem hiding this comment.
Should the modulenames set be deferred until the frame -> instance -> module mapping can be created? Otherwise there isn't anything pointing to the module names I think?
There was a problem hiding this comment.
Yeah I debated leaving that out, since it's essentially the same deal as instances. I'll remove it.
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "cranelift", "cranelift:wasm", "wasmtime:api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
|
@pchickey I'll defer to you on whether we want to merge this before or after your preview-2 support branch. I'm going to leave it for now so I don't hit you with any additional rebase burden. |
3 participants
This included stubbing out unimplemented GC-related things and updating coredump generation to include the coredump spec changes.
This is to unblock #6385 (comment), where @pchickey is running into some duplicate dependencies issues.