Make some MemFlags functions const#7903
Merged
elliottt merged 3 commits intobytecodealliance:mainfrom Feb 9, 2024
Merged
Conversation
elliottt
force-pushed
the
trevor/const-memflags
branch
from
8e6edee to
8e95773
Compare
elliottt
force-pushed
the
trevor/const-memflags
branch
from
8e95773 to
c6e42e1
Compare
fitzgen
approved these changes
Feb 9, 2024
saulecabrera
approved these changes
Feb 9, 2024
Member
saulecabrera
left a comment
saulecabrera
left a comment
There was a problem hiding this comment.
Left one minor suggestion. Thanks for adding this!
elliottt
added a commit
to elliottt/wasmtime
that referenced
this pull request
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the setter operations on
MemFlagsto use const functions internally, allowing thewithinterface to becomeconst. This allows forMemFlagsvalues to be defined as constant, and removes the need to cache trusted and untrusted values in the winch x64 macro assembler.