Fix assertion locations in memflags after #7903#7906
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Feb 9, 2024
Merged
Fix assertion locations in memflags after #7903#7906alexcrichton merged 1 commit intobytecodealliance:mainfrom
alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
elliottt
changed the title
alexcrichton
approved these changes
Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7903 I reworked the
setandwithfunctions onMemFlagsto use thewithvariant internally, to enable further use ofconst. However, I didn't move the assertions from thesetto thewithmethods, meaning that there was now a path that would avoid them. This follow-up fixes that mistake by moving the assertions into thewithfunctions.