Promote wasmtime-wasi::preview2 to root of crate#7933
Merged
Conversation
and `sed -i 's/crate::preview2/crate/g' **/*.rs`
pchickey
changed the title
alexcrichton
approved these changes
Feb 14, 2024
sunfishcode
approved these changes
Feb 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
pchickey
force-pushed
the
pch/promote_preview2
branch
from
a25f972 to
edc7562
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
i guess we didnt build the c-api in CI with deprecation warnings denied prtest:full
pchickey
force-pushed
the
pch/promote_preview2
branch
from
2131c4f to
99aad62
Compare
Subscribe to Label Actioncc @peterhuene DetailsThis issue or pull request has been labeled: "wasi", "wasmtime:c-api"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #7881, wasi-common's re-exports from wasmtime-wasi will be marked as deprecated for the
18.0release series. This PR lands the change intomainto delete those entirely, and promotewasmtime_wasi::preview2up towasmtime_wasi's root.The
preview2feature has been removed, andpreview1-on-preview2has been renamedpreview1.