Migrate all Winch filetests to tests/disas#8243
Migrate all Winch filetests to tests/disas#8243alexcrichton merged 13 commits intobytecodealliance:mainfrom
tests/disas#8243Conversation
Use CLI syntax as that's what `flags` was repurposes as in the new test suite.
|
One change that we made to the winch disasm tests that I liked was to only print offsets after branch instructions (and always after a return). This made updates to filetests easier to read, as the diff was usually more precise. Would that be easy to add back in before this migration, or should we do that as a separate update? |
|
I saw that yeah from Winch but I ended up leaving it out in favor of printing all offsets. I was a bit confused as to why the address after a jump instruction was printed because that didn't account for fall-through-style jumps (e.g. it didn't reliably catch all jump targets). For after-ret I was also not sure that would handle the case of multiple I can add it back in though if desired! |
saulecabrera
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! I'd be in favor of considering adding back the file test formatting; even though not all cases are covered (as you've pointed out) the original motivation that Trevor and I discussed was to make any diffs easier to read.
|
Ah ok that makes sense. I've updated with that added back in plus some comments |
|
Thanks for changing the output back! |
With all Winch tests moved to `tests/disas` in bytecodealliance#8243 plus the support of `wasmtime compile -C compiler=winch` this tool should in theory be supplanted nowadays with other alternatives. This commit removes the executable and the `winch-filetests` support.
With all Winch tests moved to `tests/disas` in #8243 plus the support of `wasmtime compile -C compiler=winch` this tool should in theory be supplanted nowadays with other alternatives. This commit removes the executable and the `winch-filetests` support.
This commit builds on #8237 to migrate all Winch filetests to the top-level
tests/disas/test suite. All files are copied to atests/disas/winchfolder.This PR has a number of commit splitting out the various stages of this migration. The main changes are:
test = "winch"is now supported indisastestswasmtime compileworking to get the tests workingThe next follow-up I'd like to do is to remove the filetest infrastructure for Winch, which will probably also remove the Winch executable itself. I'll do that as a follow-up though.