Remove the winch-tools crate and CLI#8248
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Mar 27, 2024
Merged
Conversation
With all Winch tests moved to `tests/disas` in bytecodealliance#8243 plus the support of `wasmtime compile -C compiler=winch` this tool should in theory be supplanted nowadays with other alternatives. This commit removes the executable and the `winch-filetests` support.
Member
Author
|
I'll note that I'm not wed to this at all, and @saulecabrera or @elliottt or others find this tool useful I'm happy to close this. This can mostly be seen as asking the question of "with today's integration of Winch, is this executable still needed?" |
saulecabrera
approved these changes
Mar 27, 2024
Member
saulecabrera
left a comment
saulecabrera
left a comment
There was a problem hiding this comment.
Makes sense to me. I don't have any particular concerns with removing this crate. Personally I feel that this crate was mostly useful in the early days when Winch was not fully integrated with Wasmtime, then it was mostly kept around for filetests.
elliottt
approved these changes
Mar 27, 2024
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
saulecabrera
added a commit
to saulecabrera/wasmtime
that referenced
this pull request
Apr 10, 2024
This commit is a follow-up to bytecodealliance#8248, in which the `winch-tools` tool was removed. It's in my todo list to follow-up with a PR with more in-deptch documentation about Winch.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2024
This commit is a follow-up to #8248, in which the `winch-tools` tool was removed. It's in my todo list to follow-up with a PR with more in-deptch documentation about Winch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With all Winch tests moved to
tests/disasin #8243 plus the support ofwasmtime compile -C compiler=winchthis tool should in theory be supplanted nowadays with other alternatives. This commit removes the executable and thewinch-filetestssupport.