Merged
Conversation
this applies a fix for windows-gnullvm targets
Contributor
Author
|
I don't understand CI failure :( |
Member
|
Thanks for the PR! This is holiday season for a number of maintainers (including myself) so it'll be a week or two before I can review this at least. There's some more information about dependencies of wasmtime here if you're interested in the meantime though. |
Member
|
The CI error here was because of the missing vet entries which maintainers manage as opposed to authors. I've added the vets here and once CI finishes this'll make its way to the merge queue. Thanks again for this! |
alexcrichton
approved these changes
Jan 6, 2025
Contributor
Author
|
thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this applies a fix for windows-gnullvm targets