Guest C custom sections containing component types#347
Merged
pchickey merged 11 commits intobytecodealliance:mainfrom Oct 5, 2022
Merged
Guest C custom sections containing component types#347pchickey merged 11 commits intobytecodealliance:mainfrom
pchickey merged 11 commits intobytecodealliance:mainfrom
Conversation
pchickey
force-pushed
the
guest_c_custom_sections
branch
from
0c6b397 to
2ec0c0b
Compare
Member
|
Nice! This looks great to me 👍 |
pchickey
force-pushed
the
guest_c_custom_sections
branch
from
2ec0c0b to
4eda9f8
Compare
added 6 commits
October 5, 2022 10:39
so that I can use it in all these structs that derive Default which peter likes to use as a constructor. Its a nice pattern tbh
and use some symbol trickery to try to get it linked into the final binary
wasi-libc ends up always importing these for stdio vtables
pchickey
force-pushed
the
guest_c_custom_sections
branch
from
4eda9f8 to
3a92b74
Compare
alexcrichton
approved these changes
Oct 5, 2022
added 5 commits
October 5, 2022 12:00
Contributor
Author
Collaborator
Thanks for the heads up. It shouldn't be hard to do in TeaVM -- I'll take a look when I have some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the custom section component types generation to the guest C generator.
Also tests that TeaVM guests can be translated to components as well. In the TeaVM case, we explicitly pass the imports and export interface to the ComponentEncoder.
I added stub functions to the WASI adapter for the additional functions required by wasi-libc and the TeaVM guests.