Compile test cases with wasm32-wasi again#349
Merged
pchickey merged 1 commit intobytecodealliance:mainfrom Oct 5, 2022
Merged
Conversation
This commit is the next step in integrating `wasm32-wasi`, `wit-bindgen`, tests, and components all together. Tests are now again compiled with `wasm32-wasi` and use a repo-specific adapter module (with support from bytecodealliance#338) to support transforming the final module into an actual component. In supporting this feature the support from bytecodealliance#331 is refactored into a new `extract` Rust module so the functionality can be shared between the ingestion of the main module as well as ingestion of adapter modules. Adapter modules now are also supported on the CLI as a standalone file without having to specify other options. Note that the actual `wasi_snapshot_preview1.wasm` adapter is non-functional in this commit and doesn't do anything fancy. The tests in this repository don't really need all that much and I suspect all we'll really need to implement is `fd_write` for fd 1 (as that's stdout).
pchickey
reviewed
Oct 5, 2022
Contributor
pchickey
left a comment
pchickey
left a comment
There was a problem hiding this comment.
Is it worth shipping a new wasmparser rn to resolve this todo?
|
|
||
| // TODO: should remove the custom setions decoded above from the wasm binary | ||
| // created here, and bytecodealliance/wasmparser#792 should help with that | ||
| // to make the loop above pretty small. |
Member
Author
|
In the interest of decoupling I'll work on that in parallel, github actions is having a fit right now and not actually running so it'll take a bit to land the wasmparser changes and for now the custom sections are otherwise harmless. |
pchickey
approved these changes
Oct 5, 2022
Contributor
|
Merging so I can use this in #347 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit is the next step in integrating
wasm32-wasi,wit-bindgen, tests, and components all together. Tests are now again compiled withwasm32-wasiand use a repo-specific adapter module (with support from #338) to support transforming the final module into an actual component.In supporting this feature the support from #331 is refactored into a new
extractRust module so the functionality can be shared between the ingestion of the main module as well as ingestion of adapter modules. Adapter modules now are also supported on the CLI as a standalone file without having to specify other options.Note that the actual
wasi_snapshot_preview1.wasmadapter is non-functional in this commit and doesn't do anything fancy. The tests in this repository don't really need all that much and I suspect all we'll really need to implement isfd_writefor fd 1 (as that's stdout).