fix(network): Make forget() and forget_vpn() idempotent#200
Merged
cachebag merged 2 commits intocachebag:masterfrom Jan 21, 2026
Merged
fix(network): Make forget() and forget_vpn() idempotent#200cachebag merged 2 commits intocachebag:masterfrom
cachebag merged 2 commits intocachebag:masterfrom
Conversation
cachebag
requested changes
Jan 20, 2026
Owner
There was a problem hiding this comment.
Could you take a look at the conflict? Make sure you rebase off of master.
@neonbit101
For reference, we should include the code for checking that device_type is bluetooth, but add your changes for returning Ok() to match this PR's intent.
This LGTM otherwise, thank you!
ruthwik-01
force-pushed
the
master
branch
3 times, most recently
from
d881a8a to
7769deb
Compare
Contributor
Author
|
Hey @cachebag, I have made the changes regarding the merge conflicts. |
cachebag
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #186
This PR makes the
forget()andforget_vpn()methods idempotent, just like howdisconnect_vpn()behaves.Previously, calling these methods on a non-existing network or VPN would return a
NoSavedConnectionerror. Now, they returnOk(())even if the target connection is not present, making them more user-friendly.Changes
forget()to not throw error if no matching Wi-Fi connections exist.forget_vpn()to not fail if the VPN is already disconnected or missing.