fix(tests): idempotence enforcement for forget_vpn()#232
Merged
cachebag merged 1 commit intocachebag:masterfrom Jan 25, 2026
Merged
fix(tests): idempotence enforcement for forget_vpn()#232cachebag merged 1 commit intocachebag:masterfrom
forget_vpn()#232cachebag merged 1 commit intocachebag:masterfrom
Conversation
f6edea0 to
51dc7c2
Compare
forget_vpn()
51dc7c2 to
f6edea0
Compare
cachebag
requested changes
Jan 25, 2026
f941000 to
51b1598
Compare
cachebag
requested changes
Jan 25, 2026
Owner
cachebag
left a comment
There was a problem hiding this comment.
Thanks! Could you ensure this change is contained to one commit? It's not desirable to apply commit suggestions via GitHub, you should always amend commits off your branch locally.
51b1598 to
138f83f
Compare
138f83f to
e4d5c27
Compare
e4d5c27 to
775ec4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the suggested changes for integration test.
As per #200 the forget and forget_vpn methods are idempotent, and in case of no-existent profile/connection it should not fail.
Previously error was expected in these cases. But after #200 we should get Ok( ( ) ).
Changes