⚡ Bolt: Fix TaskGroup serialization in NodeModulesScanner#210
⚡ Bolt: Fix TaskGroup serialization in NodeModulesScanner#210
Conversation
Added the `nonisolated` keyword to `findNodeModules` and `directorySize` in `NodeModulesScanner` to prevent execution serialization on the actor's executor. This allows these computationally intensive methods to run truly concurrently on the global cooperative thread pool when invoked from within a TaskGroup. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
nonisolatedkeyword tofindNodeModulesanddirectorySizeinNodeModulesScanner.TaskGroupsubtask serializes execution on the actor's executor, completely eliminating parallelism. Making these methodsnonisolatedensures they run concurrently on the global pool.node_modulesby actually processing directories in parallel as originally intended.PR created automatically by Jules for task 4900282487562487202 started by @acebytes