Skip to content

⚡ Bolt: Fix TaskGroup serialization in NodeModulesScanner#210

Open
acebytes wants to merge 1 commit intomainfrom
bolt/fix-taskgroup-serialization-4900282487562487202
Open

⚡ Bolt: Fix TaskGroup serialization in NodeModulesScanner#210
acebytes wants to merge 1 commit intomainfrom
bolt/fix-taskgroup-serialization-4900282487562487202

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented May 4, 2026

  • 💡 What: Added the nonisolated keyword to findNodeModules and directorySize in NodeModulesScanner.
  • 🎯 Why: In Swift Concurrency, calling an actor-isolated method from inside a TaskGroup subtask serializes execution on the actor's executor, completely eliminating parallelism. Making these methods nonisolated ensures they run concurrently on the global pool.
  • 📊 Impact: Significant reduction in scan time for node_modules by actually processing directories in parallel as originally intended.
  • 🔬 Measurement: Verify scan speed using the CLI or UI; it should complete noticeably faster on systems with multiple large project directories.

PR created automatically by Jules for task 4900282487562487202 started by @acebytes

Added the `nonisolated` keyword to `findNodeModules` and `directorySize` in `NodeModulesScanner` to prevent execution serialization on the actor's executor. This allows these computationally intensive methods to run truly concurrently on the global cooperative thread pool when invoked from within a TaskGroup.

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant