Skip to content

⚡ Bolt: Fix TaskGroup serialization in NodeModulesScanner #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acebytes wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Bolt: Fix TaskGroup serialization in NodeModulesScanner #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-04 - TaskGroup Serialization in Actors
**Learning:** In Swift Concurrency, when an actor creates a `TaskGroup` and its subtasks call an `isolated` method on the same actor, execution is serialized on the actor's executor, destroying parallelism.
**Action:** Mark computationally intensive or state-independent methods called from `TaskGroup` subtasks as `nonisolated` (like `NodeModulesScanner.findNodeModules`) so they run concurrently on the global pool.
6 changes: 4 additions & 2 deletions Sources/Cacheout/Scanner/NodeModulesScanner.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ actor NodeModulesScanner {
.sorted { $0.sizeBytes > $1.sizeBytes }
}

private func findNodeModules(in directory: URL, maxDepth: Int, currentDepth: Int = 0) async -> [NodeModulesItem] {
nonisolated private func findNodeModules(in directory: URL, maxDepth: Int, currentDepth: Int = 0) async -> [NodeModulesItem] {
let fileManager = FileManager.default
guard currentDepth < maxDepth else { return [] }

var results: [NodeModulesItem] = []
Expand Down Expand Up @@ -120,7 +121,8 @@ actor NodeModulesScanner {
return results
}

private func directorySize(at url: URL) -> Int64 {
nonisolated private func directorySize(at url: URL) -> Int64 {
let fileManager = FileManager.default
var total: Int64 = 0
guard let enumerator = fileManager.enumerator(
at: url,
Expand Down