Conversation
Marked `findNodeModules` and `directorySize` as `nonisolated` to allow `TaskGroup` subtasks to run in parallel on the global thread pool instead of being serialized on the actor. Combined separate `fileExists` and `attributesOfItem` calls into a single `URL.resourceValues` call. Passed `FileManager` as an argument to maintain dependency injection. Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f72f930d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let values = try? nodeModulesURL.resourceValues(forKeys: [.isDirectoryKey, .contentModificationDateKey]), | ||
| values.isDirectory == true { |
There was a problem hiding this comment.
This check regresses detection of node_modules when the path is a symbolic link to a directory. URL.resourceValues(...).isDirectory reports false for symlinks, while the previous fileExists(atPath:isDirectory:) path treated a symlinked directory as a directory, so these projects are now silently omitted from scan results. This affects users who relocate node_modules via symlink (for example to another volume) and leads to under-reporting reclaimable disk usage.
Useful? React with 👍 / 👎.
|
Closing as duplicate of #216 — same |
Understood. Acknowledging that this work is a duplicate and stopping work on this task. |
1 participant
💡 What: Marked
findNodeModulesanddirectorySizeinNodeModulesScannerasnonisolatedto prevent task serialization on the actor. Replaced multipleFileManagercheck/attribute calls with a singleURL.resourceValues(forKeys:)check. Passed the instance'sFileManageras a parameter to the recursive calls instead of hardcodingFileManager.default.🎯 Why: In Swift Concurrency,
TaskGroupsubtasks calling an isolated method on the same actor will be serialized on that actor's executor, destroying parallelism. Separately, combining existence and attribute checks reduces redundant filesystem syscalls. Passing theFileManagerensures the class remains testable and dependency injection isn't broken.📊 Impact: Scanning performance is significantly increased because directory trees can now be searched genuinely in parallel. File system I/O overhead is reduced.
🔬 Measurement: Run the application and observe the latency for node_modules discovery, verifying that multiple cores are utilized.
PR created automatically by Jules for task 6889912269856652472 started by @acebytes