Skip to content

⚡ Bolt: Make NodeModulesScanner truly concurrent and reduce syscalls#216

Merged
acebytes merged 1 commit intomainfrom
bolt/parallel-scanner-14809416139662999405
May 5, 2026
Merged

⚡ Bolt: Make NodeModulesScanner truly concurrent and reduce syscalls#216
acebytes merged 1 commit intomainfrom
bolt/parallel-scanner-14809416139662999405

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented May 5, 2026

💡 What: Made findNodeModules and directorySize in NodeModulesScanner static (which makes them implicitly nonisolated) to allow TaskGroup subtasks to execute concurrently instead of being serialized on the actor's executor. Passed FileManager and skipDirs explicitly to avoid instance captures. Also replaced separate FileManager checks with a single URL.resourceValues query.

🎯 Why: Subtasks calling an isolated method on the same actor run serially, bottlenecking the recursive scan. In addition, separate fileExists and attributesOfItem calls result in unoptimized multiple syscalls.

📊 Impact: Considerably speeds up filesystem scanning by parallelizing root directory traversals across available cores, and reduces syscall overhead when examining node_modules folders.

🔬 Measurement: Run the application and observe the faster discovery of node_modules via the UI or by measuring the execution time of the NodeModulesScanner.scan method.


PR created automatically by Jules for task 14809416139662999405 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de09f66e96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

var isDir: ObjCBool = false
if fileManager.fileExists(atPath: nodeModulesURL.path, isDirectory: &isDir), isDir.boolValue {
let size = directorySize(at: nodeModulesURL)
if let values = try? nodeModulesURL.resourceValues(forKeys: [.isDirectoryKey, .contentModificationDateKey]), values.isDirectory == true {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Treat symlinked node_modules as directories

Using resourceValues(...).isDirectory == true stops detecting node_modules when that path is a symbolic link to a directory. FileManager.fileExists(atPath:isDirectory:) (the previous logic) reports such symlinks as directories, but isDirectoryKey on the symlink URL is false, so these projects are now skipped entirely and their cache size is never reported. This affects setups that symlink node_modules (common in some workspace/tooling layouts).

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant