Skip to content

⚡ Bolt: Fix parallel scanning serialization bottleneck#51

Closed
acebytes wants to merge 1 commit intomainfrom
jules-2700170780368979529-50b59853
Closed

⚡ Bolt: Fix parallel scanning serialization bottleneck#51
acebytes wants to merge 1 commit intomainfrom
jules-2700170780368979529-50b59853

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

💡 What: Changed NodeModulesScanner and CacheScanner from actor to struct to enable true parallel scanning.

🎯 Why: In Swift structured concurrency, using withTaskGroup inside an actor and calling its own methods (like findNodeModules) forces all child tasks onto the actor's single executor. This inadvertently serialized the blocking I/O operations (FileManager.default), completely preventing parallel execution. Since neither type has mutable state, converting them to structs solves this.

📊 Impact: Significantly speeds up scanning (especially node_modules scanning on large file trees) by allowing tasks to truly run concurrently across the cooperative thread pool.

🔬 Measurement: Run a scan over a large directory with many node_modules. Observe CPU core utilization (should be multithreaded) and overall wall-clock completion time.


PR created automatically by Jules for task 2700170780368979529 started by @acebytes

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@acebytes
Copy link
Copy Markdown
Contributor Author

acebytes commented May 5, 2026

Closing as superseded by merged #216 (NodeModulesScanner static/nonisolated refactor) + #206 (CacheScanner.scanCategory/directorySize marked nonisolated). The TaskGroup serialization bottleneck for both scanners is now resolved with the surgical nonisolated approach instead of converting actors to structs (CacheCleaner stays an actor since it isn't run in a TaskGroup).

@acebytes acebytes closed this May 5, 2026
@google-labs-jules
Copy link
Copy Markdown
Contributor

Closing as superseded by merged #216 (NodeModulesScanner static/nonisolated refactor) + #206 (CacheScanner.scanCategory/directorySize marked nonisolated). The TaskGroup serialization bottleneck for both scanners is now resolved with the surgical nonisolated approach instead of converting actors to structs (CacheCleaner stays an actor since it isn't run in a TaskGroup).

Understood. Acknowledging that this work is now obsolete and superseded by the nonisolated refactors in #216 and #206. Stopping work on this task.

@acebytes acebytes deleted the jules-2700170780368979529-50b59853 branch May 6, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant