Skip to content

⚡ Bolt: Prevent serialisation bottleneck by converting Scanner actors to structs#90

Closed
acebytes wants to merge 1 commit intomainfrom
bolt-scanner-structs-6970769507282085271
Closed

⚡ Bolt: Prevent serialisation bottleneck by converting Scanner actors to structs#90
acebytes wants to merge 1 commit intomainfrom
bolt-scanner-structs-6970769507282085271

Conversation

@acebytes
Copy link
Copy Markdown
Contributor

@acebytes acebytes commented Apr 6, 2026

💡 What: Converted CacheScanner and NodeModulesScanner from actor to struct and added explicit performance documentation.

🎯 Why: Using an actor to manage a withTaskGroup where child tasks invoke blocking methods on self inadvertently serializes the tasks on the actor's context, destroying parallelism. Since these scanners are stateless components that only interact with thread-safe dependencies (FileManager.default), actor isolation is unnecessary. Changing them to structs allows the recursive filesystem traversals and size calculations to run truly concurrently across multiple threads.

📊 Impact: Drastically reduces scan time for deep hierarchies and large file systems by unlocking true hardware parallelism.

🔬 Measurement: Verify by running the application and observing the time taken to complete a full scan of all cache categories and node_modules directories; the duration should be noticeably shorter, particularly on systems with many files.


PR created automatically by Jules for task 6970769507282085271 started by @acebytes

… to structs

Co-authored-by: acebytes <2820910+acebytes@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@acebytes
Copy link
Copy Markdown
Contributor Author

acebytes commented May 5, 2026

Closing as superseded by merged #216 (NodeModulesScanner static/nonisolated refactor) + #206 (CacheScanner.scanCategory/directorySize marked nonisolated). The TaskGroup serialization bottleneck for both scanners is now resolved with the surgical nonisolated approach instead of converting actors to structs (CacheCleaner stays an actor since it isn't run in a TaskGroup).

@acebytes acebytes closed this May 5, 2026
@google-labs-jules
Copy link
Copy Markdown
Contributor

Closing as superseded by merged #216 (NodeModulesScanner static/nonisolated refactor) + #206 (CacheScanner.scanCategory/directorySize marked nonisolated). The TaskGroup serialization bottleneck for both scanners is now resolved with the surgical nonisolated approach instead of converting actors to structs (CacheCleaner stays an actor since it isn't run in a TaskGroup).

Understood. Acknowledging that this work is superseded and stopping work on this task.

@acebytes acebytes deleted the bolt-scanner-structs-6970769507282085271 branch May 6, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant