Remove old python code #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russella-acm
approved these changes
Dec 6, 2024
Contributor
russella-acm
left a comment
russella-acm
left a comment
There was a problem hiding this comment.
LGTM - Thank you so much for this contribution @mikemanger - your work here much appreciated! The code is a lot neater thanks to the upgrade.
I checked out the changes here, ran it locally, ran unit tests. I also verified that the package six is no longer required. All working nicely.
I will merge this and then package it up in a new version, 8.0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've ran
pyupgrade --py36-pluson the project. This has tidied up a few things:sixrequirementSSLContext.wrap_socket()as it is available in Python 3.6.This fixes #80