Using a common dependency for all bootstrap components#2
Open
jaycetde wants to merge 2 commits intocamshaft:masterfrom
Open
Using a common dependency for all bootstrap components#2jaycetde wants to merge 2 commits intocamshaft:masterfrom
jaycetde wants to merge 2 commits intocamshaft:masterfrom
Conversation
Owner
|
The main problem is how bootstrap is implemented. They add those random rules in the variables.less file. I think it would be better to make a PR to bootstrap and have them fix it. I want to do the minimal amount of change to the output of running it through the preprocessor. It becomes a nightmare to manage if I have to go delete stuff every time there's a release |
Owner
|
Sorry. It's actually in the mixins file. |
This was referenced Apr 26, 2013
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since all bootstrap components contain a few common css rules, you should have another repo as a common dependency so that the final build doesn't have the same list of rules listed up to 8 times.
I'll wait for your acceptance on this request before I post requests on all your other bootstrap-* repos