Move mixins.less rules to a separate file#7697
Closed
jaycetde wants to merge 1 commit intotwbs:3.0.0-wipfrom
jaycetde:master
Closed
Move mixins.less rules to a separate file#7697jaycetde wants to merge 1 commit intotwbs:3.0.0-wipfrom jaycetde:master
jaycetde wants to merge 1 commit intotwbs:3.0.0-wipfrom
jaycetde:master
Conversation
Member
|
Thanks, but we already addressed this in v3. It's come up a few times since then, so do pop in and check it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
camshaft/bootstrap-reset#2 - Reason for the pull request
Rules don't belong in the mixins file and moving them into a separate file will make it easier to maintain components.
Components of each component (sorry for the name collision) require these rules, and, when built, repeat them for each component added. To prevent the repetition, simply move the rules to a new file. On each update of bootstrap, these component repos can be updated by updating and pre-processing instead of finding and replacing common rules manually. Plus it just makes sense to me.