Skip to content

Allow Vultr to set MTU and use as-is configs#1037

Merged
TheRealFalcon merged 20 commits into
canonical:mainfrom
eb3095:vultr-nightly
Oct 4, 2021
Merged

Allow Vultr to set MTU and use as-is configs#1037
TheRealFalcon merged 20 commits into
canonical:mainfrom
eb3095:vultr-nightly

Conversation

@eb3095
Copy link
Copy Markdown
Contributor

@eb3095 eb3095 commented Sep 28, 2021

Proposed Commit Message

Allow Vultr to set MTU, accept-ra, routes, and use as-is configs

Add MTU, accept-ra, routes, options and a direct way to provide intact 
cloud configs for networking opposed to relying on configurations that 
may need changed often.

Additional Context

Our VPC project required a few more things than I was aware of . Sorry for the multiple PR's

Checklist:

  • [ X ] My code follows the process laid out in the documentation
  • [ X ] I have updated or added any unit tests accordingly
  • [ X ] I have updated or added any documentation accordingly

Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! My only comment is a minor naming issue.

Comment thread cloudinit/sources/helpers/vultr.py Outdated
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TheRealFalcon
Copy link
Copy Markdown
Contributor

FYI, travis is currently broken on main, so I won't be landing this PR until it is fixed. This has nothing to do with your PR. It should get fixed with #1043

@eb3095
Copy link
Copy Markdown
Contributor Author

eb3095 commented Sep 30, 2021

Yeah I saw that one last night. That's fine. I'll keep an eye on it and merge in main again when its in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants