Skip to content

Pin jsonschema to 3.2.0 (SC-466)#1043

Merged
blackboxsw merged 1 commit into
canonical:mainfrom
TheRealFalcon:pin-jsonschema
Sep 30, 2021
Merged

Pin jsonschema to 3.2.0 (SC-466)#1043
blackboxsw merged 1 commit into
canonical:mainfrom
TheRealFalcon:pin-jsonschema

Conversation

@TheRealFalcon
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon commented Sep 30, 2021

Proposed Commit Message

Pin jsonschema to 3.2.0

On unit tests, tox is attempting to install 4.0, which fails two of
the unit tests, and fails python 3.5 as it is not compatible.

Additional Context

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@TheRealFalcon TheRealFalcon changed the title WIP: pin jsonschema in requirements.txt Pin jsonschema to 3.2.0 Sep 30, 2021
@TheRealFalcon TheRealFalcon changed the title Pin jsonschema to 3.2.0 Pin jsonschema to 3.2.0 (SC-466) Sep 30, 2021
Copy link
Copy Markdown
Collaborator

@blackboxsw blackboxsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Landing this as it unblocks CI, but the 4.0.1 release (released yesterday) of jsonschema no longer rasises expected schemavalidation errrors. due to 'format': 'hostname' declarations. I think we should sort that inconsistency with a followup PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants