Skip to content

lp-to-git-users: adding vholer#1044

Merged
TheRealFalcon merged 2 commits into
canonical:mainfrom
vholer:migrate-lp-to-github
Oct 4, 2021
Merged

lp-to-git-users: adding vholer#1044
TheRealFalcon merged 2 commits into
canonical:mainfrom
vholer:migrate-lp-to-github

Conversation

@vholer
Copy link
Copy Markdown
Contributor

@vholer vholer commented Sep 30, 2021

Mapped from vlastimil-holer

@TheRealFalcon
Copy link
Copy Markdown
Contributor

Verified the mapping and that the CLA has been signed.

@vholer , can you re-add the final newline in the file?

Mapped from vlastimil-holer
@vholer
Copy link
Copy Markdown
Contributor Author

vholer commented Sep 30, 2021

Fixed.

@TheRealFalcon Is it necessary to update also PR on Launchpad?
https://code.launchpad.net/~vlastimil-holer/cloud-init/+git/cloud-init/+merge/409425
Not sure why the tools/migrate-lp-user-to-github opened PRs on both.

@TheRealFalcon
Copy link
Copy Markdown
Contributor

TheRealFalcon commented Sep 30, 2021

@TheRealFalcon Is it necessary to update also PR on Launchpad?
https://code.launchpad.net/~vlastimil-holer/cloud-init/+git/cloud-init/+merge/409425
Not sure why the tools/migrate-lp-user-to-github opened PRs on both.

No, that's really strange. We don't use launchpad anymore for PRs, and anything that is there is mirrored from Github. You can delete that merge proposal.

Also, just FYI, CI is currently broken. It has nothing to do with this PR or your code, but I won't be merging anything until it is fixed. #1043 should be the fix.

@TheRealFalcon TheRealFalcon merged commit 81a8f0a into canonical:main Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants