Add necessary mocks to test_ovf unit tests#1087
Merged
Merged
Conversation
3 tasks
blackboxsw
reviewed
Oct 29, 2021
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
+1 on this. Though I think we probably should run through all tests independently to sort out other "leaks":
I think the following also fail:
FAILED tests/unittests/test_data.py
FAILED tests/unittests/test_distros/test_netconfig.py
blackboxsw
approved these changes
Oct 29, 2021
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
+1 on this fix. confirmed fix locally. there might be a few others to capture later.
This was referenced May 12, 2023
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We likely have a test somewhere not cleaning up its mocks causing tests to run after it to not have to mock things that should be mocked. When run in isolation, these tests will fail. We need to find this test and fix it, but for now, fix the lack of mocks.