sources/azure: refactor _report_ready_if_needed and _poll_imds#1222
Merged
TheRealFalcon merged 2 commits intoJan 31, 2022
Conversation
Refactor _report_ready_if_needed() to work for both Savable PPS and Runnable PPS: - rename _report_ready_if_needed() to _report_ready_for_pps() - return interface name from lease to support _poll_imds() behavior without changing it. - fixes an issue where reporting ready return value was silently ignored for Savable PPS. - add explicit handling for failure to obtain DHCP lease to result in sources.InvalidMetaDataException. Refactor _poll_imds(): - use _report_ready_for_pps() for reporting ready, removing this logic to simplify loop logic. - move netlink and vnetswitch out of while loop to simplify loop logic, leaving only reprovision polling in loop. - add explicit handling for failure to obtain DHCP lease and retry in the next iteration. Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
cjp256
force-pushed
the
azure-poll-imds-refactor-rebase
branch
from
3b959bb to
15faccc
Compare
anhvoms
approved these changes
Jan 28, 2022
Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor _report_ready_if_needed() to work for both Savable PPS
and Runnable PPS:
rename _report_ready_if_needed() to _report_ready_for_pps()
return interface name from lease to support _poll_imds() behavior
without changing it.
fixes an issue where reporting ready return value was silently
ignored for Savable PPS.
add explicit handling for failure to obtain DHCP lease to
result in sources.InvalidMetaDataException.
Refactor _poll_imds():
use _report_ready_for_pps() for reporting ready, removing this logic
to simplify loop logic.
move netlink and vnetswitch out of while loop to simplify loop logic,
leaving only reprovision polling in loop.
add explicit handling for failure to obtain DHCP lease and
retry in the next iteration.
Signed-off-by: Chris Patterson cpatterson@microsoft.com