testing: stop universally overwriting /etc/cloud/cloud.cfg.d#1237
Merged
Conversation
As part of IN_PLACE testing, /etc/cloud/cloud.cfg.d get overwritten by what's in the source tree. This can cause problems when the directory is mounted in, because tests need the ability to modify files in /etc/cloud. Attempting to 'lxc file push' instead will fail on LXD VMs because the LXD agent isn't available yet. If such functionality is desired, one can temporarily use the 'lxd_setup' mark while writing a test and push the files manually.
TheRealFalcon
added
wip
blackboxsw
approved these changes
Feb 3, 2022
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
This is fine as we only risk exposure for not seeing unreleased changes to ./config/ in our jenkins git jobs which set CLOUD_INIT_SOURCE=IN_PLACE. This currently would affect the cc_keyboard tests failing since we changed that on Jan 22 and don't have an SRU yet that released those config changes.
Member
|
LGTM. For what it's worth, a quick spot check shows that the overwritten files in a test instance currently match files deployed in a bionic image, so I wouldn't expect that to cause a behavior change in cloud-init. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
#1234