integration: do not LXD bind mount /etc/cloud/cloud.cfg.d#1234
Merged
blackboxsw merged 3 commits intoFeb 3, 2022
Conversation
c691889 to
b4eead3
Compare
TheRealFalcon
approved these changes
Feb 3, 2022
Contributor
TheRealFalcon
left a comment
There was a problem hiding this comment.
Good find! One question inline, but +1 since it shouldn't be a problem either way.
You also have a conflict you'll need to fix first because of my merge 😬
| ( | ||
| os.path.join(cloudinit_path, "..", "config", "cloud.cfg.d"), | ||
| "/etc/cloud/cloud.cfg.d", | ||
| "/var/tmp/etc/cloud/cloud.cfg.d", |
Contributor
There was a problem hiding this comment.
If we're pushing these files directly, there's no reason to mount this directory anymore, correct?
Collaborator
Author
There was a problem hiding this comment.
d'oh, leftover attempt to avoid the nobody/nogroup bin mount. I was originally trying to bind mount then copy the full directory from the bind-mount over to /etc/cloud/cloud.cfg.d, but I realized that I should just copy the files in the first place without the bind-mount anyway. So I'm dropping that mount defitinitions as it's unused now.
Since lxc bind mounts will be read-only as nobody:nogroup we don't want to bind mount /etc/cloud/cloud.cfg.d into the instance because some tests add artifacts to /etc/cloud/cloud.cfg.d. Also make LXD push_file pull_file methods assert that the file transfer was a success, otherwise we miss the root-cause for test failures.
b4eead3 to
a62ef18
Compare
Closed
9 tasks
7 tasks
9 tasks
8 tasks
8 tasks
8 tasks
8 tasks
7 tasks
This was referenced Dec 2, 2025
8 tasks
8 tasks
8 tasks
7 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Checklist: