Skip to content

Document waiting#6300

Merged
holmanb merged 2 commits into
canonical:mainfrom
holmanb:holmanb/document-waiting
Jul 29, 2025
Merged

Document waiting#6300
holmanb merged 2 commits into
canonical:mainfrom
holmanb:holmanb/document-waiting

Conversation

@holmanb
Copy link
Copy Markdown
Member

@holmanb holmanb commented Jul 9, 2025

Context

#6286 (comment)

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb holmanb changed the title Holmanb/document waiting Document waiting Jul 9, 2025
@github-actions github-actions Bot added the documentation This Pull Request changes documentation label Jul 9, 2025
@holmanb holmanb requested a review from TheRealFalcon July 9, 2025 23:23
Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content is good. We generally use double backticks for the inline callouts instead of single backticks, so I think it'd be better to do that for consistency.

@holmanb holmanb requested a review from TheRealFalcon July 10, 2025 17:31
@holmanb
Copy link
Copy Markdown
Member Author

holmanb commented Jul 10, 2025

Thanks for the review @TheRealFalcon. I think that I've addressed everything.

@blackboxsw
Copy link
Copy Markdown
Collaborator

blackboxsw commented Jul 10, 2025

Content is good. We generally use double backticks for the inline callouts instead of single backticks, so I think it'd be better to do that for consistency.

Yep, single backticks is italics double is bold. And italics are hard to read/see/differentiate in our RTD theme (and for those with significant dyslexia).

Copy link
Copy Markdown
Contributor

@TheRealFalcon TheRealFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@holmanb holmanb force-pushed the holmanb/document-waiting branch from 7aa2f56 to 1878b19 Compare July 15, 2025 21:08
@TheRealFalcon
Copy link
Copy Markdown
Contributor

@holmanb , since you specified rebase, I'm leaving it up to you to merge.

@holmanb holmanb merged commit 60d40ba into canonical:main Jul 29, 2025
22 checks passed
@Jalle19
Copy link
Copy Markdown

Jalle19 commented Aug 29, 2025

It should perhaps be noted that if you have two services, A and B, where A depends on B, and B needs to wait for cloud-init, you have to add After=multi-user.target cloud-final.service to both A and B. It's not enough to have simply After=B.service in service A, since it will still be adding that undocumented Before=multi-user.target dependency due to it having WantedBy=multi-user.target.

I really don't understand why cloud-final.service runs after multi-user.target. Standard practice is that the system is completely started when multi-user.target is reached. That's no longer the case when cloud-init is involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This Pull Request changes documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants