Fix expire passwords for hashed passwords#1577
Merged
TheRealFalcon merged 6 commits intoJul 12, 2022
Merged
Conversation
SadeghHayeri
changed the title
Member
|
Thanks for putting together a contribution with a fix and tests! Can I have you please include your github username to |
Contributor
Author
|
@holmanb Done! |
Member
My apologies, I should have mentioned that the file is in alphabetical order, could you please make that change?
|
Contributor
Author
|
Done. |
TheRealFalcon
approved these changes
Jul 12, 2022
Contributor
TheRealFalcon
left a comment
TheRealFalcon
left a comment
There was a problem hiding this comment.
@SadeghHayeri , there was still a black formatting failure that I took the liberty of fixing. If everything passes now, we'll go ahead and merge. Thanks for the contribution!
cjp256
added a commit
to cjp256/cloud-init
that referenced
this pull request
Jul 14, 2022
This reverts commit e0416cd.
cjp256
added a commit
to cjp256/cloud-init
that referenced
this pull request
Jul 14, 2022
The password is still set for the default (admin) user but isn't immediately expired as a result of this change: canonical#1577 Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
cjp256
added a commit
to cjp256/cloud-init
that referenced
this pull request
Jul 14, 2022
The password is still set for the default (admin) user but isn't immediately expired as a result of this change: canonical#1577 Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
blackboxsw
pushed a commit
that referenced
this pull request
Jul 21, 2022
Use `hashed_passwd` instead of `passwd`. The password is still set for the default (admin) user but isn't immediately expired as a result of this change: #1577 Signed-off-by: Chris Patterson <cpatterson@microsoft.com>
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message