sources/azure: don't set cfg["password"] for default user pw

[cjp256]

The password is still set for the default (admin) user but isn't
immediately expired as a result of this change:
#1577

Signed-off-by: Chris Patterson cpatterson@microsoft.com

[cjp256]

Actually this may still be a problem if the user already exists in the image based on: #671

[TheRealFalcon]

@cjp256 I believe if you use defuser[plain_text_passwd] defuser[hashed_passwd] rather than defuser[passwd], it will work if the user already exists as well, but it will not expire it.

Looking specifically at https://github.com/canonical/cloud-init/blob/main/cloudinit/distros/__init__.py#L636

passwd gets passed unadulterated to useradd, but hashed_passwd and plain_text_passwd get processed separately by chpasswd, so those two should have the password set regardless of if the user if pre-existing or not.

[blackboxsw]

@TheRealFalcon so is this really just the suggestion then below?

Suggested change

	defuser["passwd"] = encrypt_pass(ovf_env.password)
	defuser["hashed_passwd"] = encrypt_pass(ovf_env.password)

[TheRealFalcon]

I took the liberty of pushing the suggested change to this branch.

@anhvoms , do you happen to have any context for these changes. Particular this comment related to this PR?

We're thinking the changes here should fix the issue mentioned by cjp256. Is there any way you can confirm so we don't continue to break Azure functionality?

[anhvoms]

I took the liberty of pushing the suggested change to this branch.

@anhvoms , do you happen to have any context for these changes. Particular this comment related to this PR?

We're thinking the changes here should fix the issue mentioned by cjp256. Is there any way you can confirm so we don't continue to break Azure functionality?

I had a discussion last week with Christopher and I am aware of the issue. I will get this tested and update back next week

[anhvoms]

@TheRealFalcon @blackboxsw I have tested this change and it's working as expected for both scenarios (new user with password, existing user with password)

[blackboxsw]

Thanks @anhvoms confirmed on our side too this appears to work as expected using hashed_passwd instead of passwd.