vultr: remove check_route check

[zimbatm]

Proposed Commit Message

vultr: remove check_route check

The heuristic is assuming that the URL will contain an IP, and that the
route explicitly lists that IP (eg: 0.0.0.0/0 should match but doesn't).
In order for the heuristic to be 100% reliable, it would have to
replicate exactly what the system is doing both in terms of DNS and
route resolution.

Because the HTTP request below is already exercising the python and
system resolution, it is simpler to just remove this check and lean on
the HTTP request to provide the answer if the network is up or not.

Additional Context

Test Steps

Checklist:

• My code follows the process laid out in the documentation
• I have updated or added any unit tests accordingly
• I have updated or added any documentation accordingly

[zimbatm]

I might have encountered this issue because the routes set by #2125 are different than dhclient.

[igalic]

👍

[zimbatm]

Is there anything I can do to help this PR move forward?

[TheRealFalcon]

Thanks for the PR @zimbatm .
I noticed you signed the CLA, but haven't yet added yourself to the CLA signers file. As part of this PR, please also add your name (alphabetically) to the CLA signers file. The full details are described in the last bullet point of the documentation.

@eb3095 Would you mind reviewing this?

[github-actions]

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

[TheRealFalcon]

I think this one has waited long enough. The changes here look good. Worst case scenario looks like we'll get a couple extra DHCP error log messages.

There's still a linting error to fix and the cla signers file will need to be rebased, but then we should be good to go on this one!

[zimbatm]

thanks, fixed!

[TheRealFalcon]

LGTM, thanks!