Skip to content

net/dhcp: add udhcpc support#4190

Merged
holmanb merged 1 commit into
canonical:mainfrom
jfroche:dhcp-udhcpc
Jul 18, 2023
Merged

net/dhcp: add udhcpc support#4190
holmanb merged 1 commit into
canonical:mainfrom
jfroche:dhcp-udhcpc

Conversation

@jfroche
Copy link
Copy Markdown
Contributor

@jfroche jfroche commented Jun 19, 2023

Proposed Commit Message

The currently used dhcp client, dhclient, is coming from the unmaintained package,
`isc-dhcp-client` (refer https://www.isc.org/dhcp/) which ended support in 2022.

This change introduce support for the dhcp client, udhcpc, from the busybox project.
Busybox advantages are that it is available across many distributions and comes with
lightweight executables.

Additional Context

Already discussed in #2125

Test Steps

Checklist:

  • My code follows the process laid out in the documentation
  • I have updated or added any unit tests accordingly
  • I have updated or added any documentation accordingly

@jfroche jfroche force-pushed the dhcp-udhcpc branch 2 times, most recently from 69c915c to f517b90 Compare June 19, 2023 14:32
wegank pushed a commit to NixOS/nixpkgs that referenced this pull request Jun 19, 2023
Keep support for udhcpc (waiting for upstream PR:
canonical/cloud-init#4190).

Vultr patch has been merged upstream
(canonical/cloud-init#2151).
@holmanb holmanb self-assigned this Jun 20, 2023
The currently used dhcp client, dhclient, is coming from the unmaintained package, isc-dhcp-client (refer https://www.isc.org/dhcp/) which ended support in 2022.

This change introduce support for the dhcp client, udhcpc, from the busybox project. Busybox advantages are that it is available across many distributions and comes with lightweight executables.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 8, 2023

Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close.

If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging TheRealFalcon, and he will ensure that someone takes a look soon.

(If the pull request is closed and you would like to continue working on it, please do tag TheRealFalcon to reopen it.)

@github-actions github-actions Bot added the stale-pr Pull request is stale; will be auto-closed soon label Jul 8, 2023
@holmanb holmanb removed the stale-pr Pull request is stale; will be auto-closed soon label Jul 10, 2023
@holmanb
Copy link
Copy Markdown
Member

holmanb commented Jul 10, 2023

@jfroche Thanks for putting this together. Since there hasn't been any further activity I assume this is ready for review now?

  • CLA signed, thanks!

@holmanb
Copy link
Copy Markdown
Member

holmanb commented Jul 17, 2023

I'll test this out, thanks.

At first glance it looks like the generic implementation should work, but I don't see the datasource-specific methods implemented which means that this implementation might not work on all clouds.

@jfroche Are there plans to implement those in a follow up PR?

Copy link
Copy Markdown
Member

@holmanb holmanb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out. It looks good to me.

Here is a log file for an Ubuntu instance using udhcp to set up an ephemeral network using this PR. Future cloud-specific implementation support would be a nice to have for udhcp, but this is a nice addition as is so I'll merge it now.

Thanks @jfroche!

@holmanb holmanb merged commit ce7d597 into canonical:main Jul 18, 2023
@jfroche
Copy link
Copy Markdown
Contributor Author

jfroche commented Jul 18, 2023

datasource-specific methods

I'll test this out, thanks.

At first glance it looks like the generic implementation should work, but I don't see the datasource-specific methods implemented which means that this implementation might not work on all clouds.

@jfroche Are there plans to implement those in a follow up PR?

Yes I will make another PR for that.
Thank you for already merging this part !

TheRealFalcon pushed a commit to TheRealFalcon/cloud-init that referenced this pull request Jul 26, 2023
The currently used dhcp client, dhclient, is coming from the unmaintained package, isc-dhcp-client (refer https://www.isc.org/dhcp/) which ended support in 2022.

This change introduce support for the dhcp client, udhcpc, from the busybox project. Busybox advantages are that it is available across many distributions and comes with lightweight executables.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants