test-requirements.txt: pin pytest to <6#512
Merged
Merged
Conversation
pylint is emitting errors with pytest 6.x which are not observed on pytest 5.x. While that is resolved, pin to a lower pytest version.
Collaborator
|
Looks like a fix landed in pytest pytest-dev/pytest#7566 |
blackboxsw
reviewed
Jul 29, 2020
Collaborator
blackboxsw
left a comment
blackboxsw
left a comment
There was a problem hiding this comment.
Let's either add a comment to test-requirements.txt or a breadcrumb in the commit message about the related issue which is already fixed in 6.0.x as all we are waiting for is backport of that fix to drop this change
pytest-dev/pytest#7558
blackboxsw
approved these changes
Jul 29, 2020
OddBloke
added a commit
to OddBloke/cloud-init
that referenced
this pull request
Jul 31, 2020
pytest 6.0.1 fixes the issue we had with pytest 6.0.0. This reverts commit db5c1c8.
blackboxsw
pushed a commit
that referenced
this pull request
Aug 2, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pylint is emitting errors with pytest 6.x which are not observed on
pytest 5.x. While that is resolved, pin to a lower pytest version.