[6.0.x] mark: fix pylint not-callable error on pytest.mark.parametrize(...), again#7566
Merged
Merged
Conversation
mark: fix pylint not-callable error on pytest.mark.parametrize(...), again (cherry picked from commit f9837f9)
graingert
reviewed
Jul 29, 2020
Comment on lines
+479
to
+481
| parametrize = _ParametrizeMarkDecorator(Mark("parametrize ", (), {})) | ||
| usefixtures = _UsefixturesMarkDecorator(Mark("usefixtures ", (), {})) | ||
| filterwarnings = _FilterwarningsMarkDecorator(Mark("filterwarnings ", (), {})) |
Member
There was a problem hiding this comment.
Suggested change
| parametrize = _ParametrizeMarkDecorator(Mark("parametrize ", (), {})) | |
| usefixtures = _UsefixturesMarkDecorator(Mark("usefixtures ", (), {})) | |
| filterwarnings = _FilterwarningsMarkDecorator(Mark("filterwarnings ", (), {})) | |
| parametrize = _ParametrizeMarkDecorator(Mark("parametrize", (), {})) | |
| usefixtures = _UsefixturesMarkDecorator(Mark("usefixtures", (), {})) | |
| filterwarnings = _FilterwarningsMarkDecorator(Mark("filterwarnings", (), {})) |
Member
There was a problem hiding this comment.
probably worth fixing this before the backport
Member
Author
There was a problem hiding this comment.
Thanks, I am going to fix in master and add the backport of that as well to this PR.
rodrigoalmeida94
pushed a commit
to up42/up42-py
that referenced
this pull request
Jul 29, 2020
(cherry picked from commit 54e08b7)
rodrigoalmeida94
pushed a commit
to up42/up42-py
that referenced
this pull request
Jul 29, 2020
* Ignore order of settings list * Remove duplicated method * Fix name of test * Add mock test for jobcollection download_result * Add mock jobcollection with multiple jobs * Add test for unpacking is False * Make sure folder structure is kept when unpacking * Remove warning for exotic file formats * Add merge results from job collection * format * Add live test with download DIMAP file * Make sure order of results doesn't break tests * Update fixture name * Update tests name * Use context manager for openinhg tarfile * Rename tempdir to prevent shadowing of module * Use loop to register responses * Use Path name property to prevent confusion of files * Ignore not-callable temporarily (relates to pytest-dev/pytest#7566) * Remove try except block * Glob in output_folder_path
rodrigoalmeida94
pushed a commit
to up42/up42-py
that referenced
this pull request
Jul 31, 2020
* Ignore order of settings list * Remove duplicated method * Fix name of test * Add mock test for jobcollection download_result * Add mock jobcollection with multiple jobs * Add test for unpacking is False * Make sure folder structure is kept when unpacking * Remove warning for exotic file formats * Add merge results from job collection * format * Add live test with download DIMAP file * Make sure order of results doesn't break tests * Update fixture name * Update tests name * Use context manager for openinhg tarfile * Rename tempdir to prevent shadowing of module * Use loop to register responses * Use Path name property to prevent confusion of files * Ignore not-callable temporarily (relates to pytest-dev/pytest#7566) * Remove try except block * Add subscriptable class * Add job iterator helper * Add get_jobs_info and get_jobs_status methods * Use job_iterator in download results * Clarify returns * Add iter method * Remove disabling of duplicate-code * format * remove duplicated merge block * Add test with all job collection fails / one job in jobcollection fails * Add is_succeeded property to job * Make sure jobcollection is returned if one job or all job fails * Add only_succeded flag to job iterator * job_iterator to apply * Raise value error when all jobs failed, empty jobcollection * Add docstring to apply * Add doctring * Remove space * Add TODOs * Change raise valueerror positions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7565.