test: refactor test_data.py to use only pytest#6440
Merged
Conversation
Contributor
Author
|
Hi @aciba90. Please could you review this? |
aciba90
approved these changes
Sep 1, 2025
Contributor
aciba90
left a comment
aciba90
left a comment
There was a problem hiding this comment.
LGTM, thanks!
(As this does not fully fix the referenced issue, I am going to modify the commit message to change Fixes GH-xxxx to GH-xxxx, as the former autocloses the issue.)
DarkPhily
pushed a commit
to hetznercloud/cloud-init
that referenced
this pull request
Sep 2, 2025
Remove helpers.TestCase inheritance and replace self.assert methods with bare assert statements. This change is a refactor only. Test behavior and coverage remains exactly the same. canonicalGH-6427
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Sep 3, 2025
Remove helpers.TestCase inheritance and replace self.assert methods with bare assert statements. This change is a refactor only. Test behavior and coverage remains exactly the same. canonicalGH-6427
blackboxsw
pushed a commit
to blackboxsw/cloud-init
that referenced
this pull request
Sep 3, 2025
Remove helpers.TestCase inheritance and replace self.assert methods with bare assert statements. This change is a refactor only. Test behavior and coverage remains exactly the same. canonicalGH-6427
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Additional Context
Test Steps
Run the specific unit tests to verify they still pass: