Skip to content

test: refactor test_data.py to use only pytest #6440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aciba90 merged 1 commit into from
Sep 1, 2025
Merged

test: refactor test_data.py to use only pytest #6440

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions tests/unittests/test_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
from cloudinit import util
from cloudinit.config.modules import Modules
from cloudinit.settings import DEFAULT_RUN_DIR, PER_INSTANCE
from tests.unittests import helpers
from tests.unittests.util import FakeDataSource

MPATH = "cloudinit.stages"
Expand Down Expand Up @@ -790,29 +789,29 @@ def test_compressed_in_userdata(self, ud_proc):
assert count_messages(message) == 1


class TestConvertString(helpers.TestCase):
class TestConvertString:
def test_handles_binary_non_utf8_decodable(self):
"""Printable unicode (not utf8-decodable) is safely converted."""
blob = b"#!/bin/bash\necho \xc3\x84\n"
msg = ud.convert_string(blob)
self.assertEqual(blob, msg.get_payload(decode=True))
assert blob == msg.get_payload(decode=True)

def test_handles_binary_utf8_decodable(self):
blob = b"\x32\x32"
msg = ud.convert_string(blob)
self.assertEqual(blob, msg.get_payload(decode=True))
assert blob == msg.get_payload(decode=True)

def test_handle_headers(self):
text = "hi mom"
msg = ud.convert_string(text)
self.assertEqual(text, msg.get_payload(decode=False))
assert text == msg.get_payload(decode=False)

def test_handle_mime_parts(self):
"""Mime parts are properly returned as a mime message."""
message = MIMEBase("text", "plain")
message.set_payload("Just text")
msg = ud.convert_string(str(message))
self.assertEqual("Just text", msg.get_payload(decode=False))
assert "Just text" == msg.get_payload(decode=False)


class TestFetchBaseConfig:
Expand Down