net: Fix static routes to host in eni renderer#668
Conversation
Route '-net' parameter is incompatible with /32 IPv4 addresses so we have to use '-host' in that case.
igalic
left a comment
There was a problem hiding this comment.
is this equally broken for IPv6?
|
No, in IPv6 mode route works well without [-host|-net] part:
|
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging mitechie, and he will ensure that someone takes a look soon. (If the pull request is closed, please do feel free to reopen it if you wish to continue working on it.) |
|
@mitechie this doesn't seem to be on anyone's radar (but that's understandable, given the current SRU work) |
|
Thanks, it's on the board of things to review/get landed after the release. We'll get caught up on it. Thanks Mina! |
|
Hey @tnt-dev , thanks for the contribution! I noticed you added yourself to the CLA signers file, but have you signed the actual CLA too? I'm not seeing your information there. If you did, can you provide the date that you signed it? We have also recently introduced integration testing into cloud-init. As part of this PR, would you be able to add an integration test for this change? test_gh626.py also uses a network config and would probably be the best example to base your test on. |
487277e to
a032850
Compare
|
CLA is signed, integration test has been added. |
TheRealFalcon
left a comment
There was a problem hiding this comment.
This update looks good. Just two more minor comments inline and then I think it'll be good to land.
|
Yes, I have removed SRU pytest decorator and have added a short comment about the source of the original problem. |
TheRealFalcon
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Route '-net' parameter is incompatible with /32 IPv4 networks without 'netmask' part so we have to use '-host' in that case.
Checklist: