-
Notifications
You must be signed in to change notification settings - Fork 1.1k
net: Fix static routes to host in eni renderer #668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
TheRealFalcon
merged 6 commits into
canonical:master
from
tnt-dev:fix-static-route-to-host-eni-render
Jan 13, 2021
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a418853
net: Fix static routes to host in eni renderer
tnt-dev be0fafe
Merge branch 'master' into fix-static-route-to-host-eni-render
tnt-dev e048499
Merge branch 'master' into fix-static-route-to-host-eni-render
tnt-dev a032850
Add integration test for #668
tnt-dev 8f14846
Update integration test for #668
tnt-dev e11d33e
Merge branch 'master' into fix-static-route-to-host-eni-render
TheRealFalcon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| """Integration test for gh-668. | ||
|
|
||
| Ensure that static route to host is working correctly. | ||
| The original problem is specific to the ENI renderer but that test is suitable | ||
| for all network configuration outputs. | ||
| """ | ||
|
|
||
| import pytest | ||
|
|
||
| from tests.integration_tests.instances import IntegrationInstance | ||
|
|
||
|
|
||
| DESTINATION_IP = "172.16.0.10" | ||
| GATEWAY_IP = "10.0.0.100" | ||
|
|
||
| NETWORK_CONFIG = """\ | ||
| version: 2 | ||
| ethernets: | ||
| eth0: | ||
| addresses: [10.0.0.10/8] | ||
| dhcp4: false | ||
| routes: | ||
| - to: {}/32 | ||
| via: {} | ||
| """.format(DESTINATION_IP, GATEWAY_IP) | ||
|
|
||
| EXPECTED_ROUTE = "{} via {}".format(DESTINATION_IP, GATEWAY_IP) | ||
|
|
||
|
|
||
| @pytest.mark.lxd_container | ||
| @pytest.mark.lxd_vm | ||
| @pytest.mark.lxd_config_dict({ | ||
| "user.network-config": NETWORK_CONFIG, | ||
| }) | ||
| def test_static_route_to_host(client: IntegrationInstance): | ||
| route = client.execute("ip route | grep {}".format(DESTINATION_IP)) | ||
| assert route.startswith(EXPECTED_ROUTE) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,7 @@ slyon | |
| smoser | ||
| sshedi | ||
| TheRealFalcon | ||
| tnt-dev | ||
| tomponline | ||
| tsanghan | ||
| WebSpider | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.