Integration test for gh-626#728
Conversation
|
It looks like, at least under Ubuntu, the netplan config renders as expected, even before the changes we're testing (but not ENI). Is this expected? |
| 'user.network-config': NETWORK_CONFIG | ||
| }) | ||
| def test_wakeonlan(client: IntegrationInstance): | ||
| if ImageSpecification.from_os_image().release == 'xenial': |
There was a problem hiding this comment.
Checking this way isn't ideal, but I see it as being short term until we come up with a better way of checking
There was a problem hiding this comment.
I'm not even sure if this is desirable, but this would DTRT even if we haven't detected a specified image as xenial:
| if ImageSpecification.from_os_image().release == 'xenial': | |
| if client.execute("lsb_release --short --codename") == "xenial": |
(Presumably "a better way" would be separate tests with appropriate release tagging?)
Ensure if wakeonlan is specified in the network config that it is rendered in the /etc/network/interfaces or netplan config.
TheRealFalcon
force-pushed
the
test-gh626
branch
from
8f8080e to
39c312c
Compare
OddBloke
left a comment
OddBloke
left a comment
There was a problem hiding this comment.
Code LGTM, and confirmed the test passes/fails as expected. (As netplan is just passthrough, we expect it to pass already; this is regression-testing that, really.) Thanks!
| 'user.network-config': NETWORK_CONFIG | ||
| }) | ||
| def test_wakeonlan(client: IntegrationInstance): | ||
| if ImageSpecification.from_os_image().release == 'xenial': |
There was a problem hiding this comment.
I'm not even sure if this is desirable, but this would DTRT even if we haven't detected a specified image as xenial:
| if ImageSpecification.from_os_image().release == 'xenial': | |
| if client.execute("lsb_release --short --codename") == "xenial": |
(Presumably "a better way" would be separate tests with appropriate release tagging?)
2 participants
Proposed Commit Message
Integration test for gh-626
Ensure if wakeonlan is specified in the network config that it is
rendered in the /etc/network/interfaces or netplan config.
Additional Context
See #626
Test Steps
pytest tests/integration_tests/bugs/test_gh626.py
Checklist: