-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Integration test for gh-626 #728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+42
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| """Integration test for gh-626. | ||
|
|
||
| Ensure if wakeonlan is specified in the network config that it is rendered | ||
| in the /etc/network/interfaces or netplan config. | ||
| """ | ||
|
|
||
| import pytest | ||
| import yaml | ||
|
|
||
| from tests.integration_tests.clouds import ImageSpecification | ||
| from tests.integration_tests.instances import IntegrationInstance | ||
|
|
||
|
|
||
| NETWORK_CONFIG = """\ | ||
| version: 2 | ||
| ethernets: | ||
| eth0: | ||
| dhcp4: true | ||
| wakeonlan: true | ||
| """ | ||
|
|
||
| EXPECTED_ENI_END = """\ | ||
| iface eth0 inet dhcp | ||
| ethernet-wol g""" | ||
|
|
||
|
|
||
| @pytest.mark.sru_2020_11 | ||
| @pytest.mark.lxd_container | ||
| @pytest.mark.lxd_vm | ||
| @pytest.mark.lxd_config_dict({ | ||
| 'user.network-config': NETWORK_CONFIG | ||
| }) | ||
| def test_wakeonlan(client: IntegrationInstance): | ||
| if ImageSpecification.from_os_image().release == 'xenial': | ||
| eni = client.execute('cat /etc/network/interfaces.d/50-cloud-init.cfg') | ||
| assert eni.endswith(EXPECTED_ENI_END) | ||
| return | ||
|
|
||
| netplan_cfg = client.execute('cat /etc/netplan/50-cloud-init.yaml') | ||
| netplan_yaml = yaml.safe_load(netplan_cfg) | ||
| assert 'wakeonlan' in netplan_yaml['network']['ethernets']['eth0'] | ||
| assert netplan_yaml['network']['ethernets']['eth0']['wakeonlan'] is True | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking this way isn't ideal, but I see it as being short term until we come up with a better way of checking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not even sure if this is desirable, but this would DTRT even if we haven't detected a specified image as
xenial:(Presumably "a better way" would be separate tests with appropriate release tagging?)