Add openstack as a testing platform#804
Conversation
OddBloke
left a comment
OddBloke
left a comment
There was a problem hiding this comment.
I've successfully run a test! A couple of small "UI" things I hit while getting that working, will review properly next.
| 'When using Openstack, `OS_IMAGE` parameter MUST take the ' | ||
| 'form of a 36-character UUID. Passing in a release name is ' |
There was a problem hiding this comment.
OS_IMAGE can still take its :: separated form (and arguably should, given we can't possibly infer OS/release at the moment), it's just the first component of that form which is constrained in this way. Something along the lines of "OS_IMAGE MUST be specified with a 36-character UUID image ID", perhaps?
There was a problem hiding this comment.
This still needs addressing, I think?
|
Hello! Thank you for this proposed change to cloud-init. This pull request is now marked as stale as it has not seen any activity in 14 days. If no activity occurs within the next 7 days, this pull request will automatically close. If you are waiting for code review and you are seeing this message, apologies! Please reply, tagging mitechie, and he will ensure that someone takes a look soon. (If the pull request is closed and you would like to continue working on it, please do tag mitechie to reopen it.) |
github-actions
Bot
added
the
stale-pr
TheRealFalcon
removed
the
stale-pr
|
@OddBloke Sorry, not looking for another review on this one yet. I'm waiting to for the pycloudlib one to land before fixing this one up. |
TheRealFalcon
changed the title
|
Drive-by thought before a meeting: do we need to expand the environment variables that tox will allow through for the OpenStack library to find credentials? |
OddBloke
left a comment
OddBloke
left a comment
There was a problem hiding this comment.
LGTM, thanks!
I'm seeing a few test failures locally, some of which are because I'm not using the latest cloud-init dev version; regardless, we can clean up any rough edges in follow-ups.
| 'a 36-character UUID image ID. Passing in a release name is ' | ||
| 'not valid here.\n' |
I don't think so. We've wildcarded the |
Maybe this is another oddity of my workflow, but I source my Nova credentials (populating a bunch of OS_* envvars); #830 fixes it for me locally. |
|
Oooooh, right. Yeah, I use env vars too. |
2 participants
Proposed Commit Message
Test Steps
set
OPENSTACK_NETWORKappropriately in user_settings.py. ThenCLOUD_INIT_PLATFORM=openstack CLOUD_INIT_OS_IMAGE=3709d596-ce0d-45ac-976a-9d2f3ce46474 pytest tests/integration_testsChecklist: