Fix attempting to decode binary data in test_seed_random_data test#806
Merged
Conversation
`test_seed_random_data.py` was failing on openstack as openstack provides additional binary seed data to the end of the specified file. The test has been changed to only read the ascii porition of seed file.
TheRealFalcon
force-pushed
the
fix-binary-test
branch
from
9611157 to
2ee7d41
Compare
3 tasks
This was referenced May 12, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Commit Message
Fix attempting to decode binary data in test_seed_random_data test
test_seed_random_data.pywas failing on openstack as openstackprovides additional binary seed data to the end of the specified file.
The test has been changed to only read the ascii porition of
seed file.
Additional Context
n/a
Test Steps
Using openstack as the testing platform (requires branch #804 if branch isn't merged yet):
pytest tests/integration_tests/modules/test_seed_random_data.pyChecklist: