-
Notifications
You must be signed in to change notification settings - Fork 1
chore(docs): update contributing guidelines (charmkeeper) #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c672d31
chore(docs): update contributing guidelines (charmkeeper)
erinecon 503aca3
fix(docs): build errors
erinecon df61d4a
chore: clarify PR checklist and remove unnecessary item
erinecon 64e9f84
chore(docs): revert changes in CONTRIBUTING.md
erinecon 83fdf02
Merge branch 'main' into charmkeeper/update-contributing-guidelines
erinecon 1f4c6c3
fix(docs): whoops we're ignoring the changelog
erinecon 3eb0a1e
Merge branch 'main' of github.com:canonical/github-runner-operators i…
erinecon a98a387
fix: update pr checklist to incorporate previous items, remove duplic…
erinecon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,29 @@ | ||
| ### Overview | ||
| #### What this PR does | ||
|
|
||
| <!-- A high level overview of the change --> | ||
| #### Why we need it | ||
|
|
||
| ### Rationale | ||
|
|
||
| <!-- The reason the change is needed --> | ||
|
|
||
| ### Checklist | ||
| #### Checklist | ||
|
|
||
| - [ ] Changes comply with the project's coding standards and guidelines (see CONTRIBUTING.md and STYLE.md) | ||
| - [ ] `CONTRIBUTING.md` has been updated upon changes to the contribution/development process (e.g. changes to the way tests are run) | ||
| - [ ] Technical author has been assigned to review the PR in case of documentation changes (usually *.md files) | ||
| - [ ] I updated `docs/changelog.md` with user-relevant changes | ||
| - [ ] I used AI to assist with preparing this PR | ||
| - [ ] I added or updated tests as needed (unit and integration) | ||
| - [ ] **If integration test modules are used:** I updated the workflow configuration | ||
| (e.g., in `.github/workflows/integration_tests.yaml`, ensure the `modules` list is correct) | ||
| - [ ] **If this PR involves a Grafana dashboard:** I added a screenshot of the dashboard | ||
| - [ ] **If this PR involves Terraform:** `terraform fmt` passes and `tflint` reports no errors | ||
| - [ ] **If this PR involves Rockcraft:** I updated the version | ||
|
|
||
| <!-- | ||
| You can adjust the checklist to match the project. | ||
|
|
||
| If you are an AI assistant (e.g., GitHub Copilot, ChatGPT, Claude), follow these instructions when generating or completing PR descriptions: | ||
|
|
||
| 1. Add a **Test plan** section explaining how the changes were tested, including any manual, unit, integration, or workflow tests. | ||
| 2. Add a **Review focus** section highlighting tricky parts, important decisions, or areas needing human attention. | ||
| 3. Identify and document any **potential breaking changes**. | ||
| 4. Highlight any **new dependencies, APIs, modules, or workflow changes** introduced by this PR. | ||
| --> | ||
|
|
||
| <!-- Explanation for any unchecked items above --> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,13 @@ | ||
| (changelog)= | ||
|
|
||
| # Changelog | ||
|
|
||
| This changelog documents user-relevant changes to the Planner charm and Webhook gateway charm. | ||
|
|
||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). | ||
|
|
||
| Each revision is versioned by the date of the revision. | ||
|
|
||
| ## 2026-04-13 | ||
|
|
||
| - add 5xx error logging to planner routes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| .. meta:: | ||
| :description: Familiarize yourself with contributing to the GitHub runner charms documentation. | ||
|
|
||
| .. _how_to_contribute: | ||
|
|
||
| How to contribute | ||
| ================= | ||
|
|
||
| .. note:: | ||
|
|
||
| See `CONTRIBUTING.md <https://github.com/canonical/github-runner-operators/blob/main/CONTRIBUTING.md>`_ | ||
| for information on contributing to the source code. | ||
|
|
||
| Our documentation is hosted on `Read the Docs <https://documentation.ubuntu.com/github-runner-operators>`_ to enable collaboration. | ||
| Please use the links on each documentation page to either | ||
| directly change something you see that's wrong, ask a question, or make a suggestion | ||
| about a potential change. | ||
|
|
||
| Our documentation is also available alongside the | ||
| `source code on GitHub <https://github.com/canonical/github-runner-operators>`_. | ||
| You may open a pull request with your documentation changes, or you can | ||
| `file a bug <https://github.com/canonical/github-runner-operators/issues>`_ | ||
| to provide constructive feedback or suggestions. | ||
|
|
||
| AI usage | ||
| -------- | ||
|
|
||
| You are free to use any tools you want while preparing your contribution, including | ||
| AI, provided that you do so lawfully and ethically. | ||
|
|
||
| Avoid using AI to complete | ||
| `Canonical Open Documentation Academy issues <https://github.com/canonical/open-documentation-academy/issues>`_. | ||
| The purpose of these issues is to provide newcomers with opportunities to | ||
| contribute to our projects and gain documentation skills. Using AI to | ||
| complete these tasks undermines their purpose. | ||
|
|
||
| If you use AI to help with your PRs, be mindful. Avoid submitting contributions | ||
| with entirely AI-generated documentation. The human aspect of documentation is | ||
| important to us, and that includes tone, syntax, perspectives, and the | ||
| occasional typo. | ||
|
|
||
| Some examples of valid AI assistance includes: | ||
|
|
||
| * Checking for spelling or grammar errors | ||
| * Drafting plans or outlines | ||
| * Checking that your contribution aligns with the Canonical style guide | ||
|
|
||
| We have created instructions and tools that you can provide AI while preparing | ||
| your contribution in `copilot-collections <https://github.com/canonical/copilot-collections>`_. | ||
| While it isn't necessary to use ``copilot-collections`` while preparing your | ||
| contribution, these files contain details about our documentation standards and | ||
| practices that will help the AI avoid common pitfalls when interacting with our | ||
| projects. By using these tools, you can avoid longer review times and nitpicks. | ||
|
|
||
| If you choose to use AI, please disclose this information to us by indicating | ||
| AI usage in the PR description (for instance, marking the checklist item about | ||
| AI usage). You don't need to go into explicit details about how and where you used AI. | ||
|
|
||
| Avoid submitting contributions that you don't fully understand. | ||
| You are responsible for the entire contribution, including the AI-assisted portions. | ||
| You must be willing to engage in discussion and respond to any questions, comments, | ||
| or suggestions we may have. | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,9 @@ | ||
| How-to guides | ||
| ============= | ||
|
|
||
| The following guides cover key processes and common tasks for managing and using the GitHub runner charms. | ||
|
|
||
| .. toctree:: | ||
| :maxdepth: 1 | ||
|
|
||
| Contribute <contribute> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.